Multi project support for the C# parser by HorvathDaniel15 · Pull Request #847 · Ericsson/CodeCompass

HorvathDaniel15 · 2026-04-04T18:02:40Z

Resolves #823

Copilot

Pull request overview

This PR extends the C# parser to accept richer inputs (solutions/projects) and to better handle multiple inputs, enabling “multi-project” parsing via Roslyn/MSBuild rather than only directory-based discovery.

Changes:

Add input validation and safer log parsing in the C++ wrapper (avoid empty-input and empty-line crashes; log non file-status output).
Update the C# parser to support .sln/.slnx and .csproj inputs using MSBuildWorkspace, with a fallback path that extracts project paths from solution files.
Add Roslyn MSBuild workspace dependency and ignore .DS_Store.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 7 comments.

File	Description
`plugins/csharp/parser/src/csharpparser.cpp`	Validates inputs and hardens parsing of the C# parser output stream.
`plugins/csharp/parser/src_csharp/Program.cs`	Implements solution/project loading via `MSBuildWorkspace` and multi-project processing with parallel document parsing.
`plugins/csharp/parser/src_csharp/CSharpParser.csproj`	Adds `Microsoft.CodeAnalysis.Workspaces.MSBuild` to support solution/project loading.
`.gitignore`	Ignores macOS `.DS_Store`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-04T18:06:54Z

+        static async Task<int> Main(string[] args)
        {
+            MSBuildLocator.RegisterDefaults();
            _rootDir = new List<string>();
            int threadNum = 4;


MSBuildLocator.RegisterDefaults() can throw (e.g., when no compatible MSBuild instance is found), which would currently crash the process before you emit any parser-friendly error output. Wrap registration in the existing argument-parsing try/catch (or a dedicated try/catch) and return a non-zero exit code with a clear message when registration fails.

This thread was resolved, but no fix is present in the codebase.

Copilot · 2026-04-04T18:06:55Z

            string csharpConnectionString = transformConnectionString();

            var options = new DbContextOptionsBuilder<CsharpDbContext>()
                            .UseNpgsql(csharpConnectionString)
                            .Options;

            CsharpDbContext _context = new CsharpDbContext(options);
            _context.Database.Migrate();


The database context is created and migrations are applied before validating that any input paths were provided. This can cause unnecessary (and potentially destructive/slow) DB work even when the CLI invocation is invalid; consider validating args/_rootDir first, then migrating/creating the DbContext only for valid runs (and disposing it via using/await using).

This thread was resolved, but no fix is present in the codebase.

Copilot · 2026-04-04T18:06:55Z

+                Console.Error.WriteLine($"Unsupported file type: {primaryInput}");
+                Console.Error.WriteLine("Supported: .sln, .slnx, .csproj");


This code writes important user-facing errors to stderr, but the C++ wrapper currently captures only stdout (bp::std_out > log). As a result, failures/diagnostics may be invisible to the caller. Consider writing these diagnostics to stdout (with a prefix) or ensure stderr is also captured/redirected by the wrapper.

Suggested change

Console.Error.WriteLine($"Unsupported file type: {primaryInput}");

Console.Error.WriteLine("Supported: .sln, .slnx, .csproj");

WriteLine($"ERROR: Unsupported file type: {primaryInput}");

WriteLine("ERROR: Supported: .sln, .slnx, .csproj");

We can keep it the current way, but this static usage for System.Console is quite odd. Please remove that and instead write Console.WriteLine() on each usage for clarity and convention purposes.

Copilot · 2026-04-04T18:06:55Z

+        private static async Task<Solution> LoadInputAsync(string inputPath)
+        {
+            if (File.Exists(inputPath))
+            {
+                if (inputPath.EndsWith(".sln", StringComparison.OrdinalIgnoreCase) ||
+                    inputPath.EndsWith(".slnx", StringComparison.OrdinalIgnoreCase))
+                {
+                    return await LoadSolutionAsync(inputPath);
+                }
+                if (inputPath.EndsWith(".csproj", StringComparison.OrdinalIgnoreCase))
+                {
+                    return await LoadProjectAsync(inputPath);
+                }
+                else
+                {
+                    Console.Error.WriteLine($"Unsupported file type: {inputPath}");
+                    Console.Error.WriteLine("Supported: .sln, .slnx, .csproj");
+                    return null;
+                }
+            }
+            if (Directory.Exists(inputPath))
+            {
+                return null;
+            }
+            else
+            {
+                Console.Error.WriteLine($"Input path not found: {inputPath}");
+                return null;
+            }
+        }
+


LoadInputAsync is not referenced anywhere in the file (no call sites). Keeping this unused method (and its error-printing branches) adds dead code and increases maintenance surface. Either remove it or refactor Main to use it so there is a single, tested input-loading pathway.

Suggested change

private static async Task<Solution> LoadInputAsync(string inputPath)

{

if (File.Exists(inputPath))

{

if (inputPath.EndsWith(".sln", StringComparison.OrdinalIgnoreCase) ||

inputPath.EndsWith(".slnx", StringComparison.OrdinalIgnoreCase))

{

return await LoadSolutionAsync(inputPath);

}

if (inputPath.EndsWith(".csproj", StringComparison.OrdinalIgnoreCase))

{

return await LoadProjectAsync(inputPath);

}

else

{

Console.Error.WriteLine($"Unsupported file type: {inputPath}");

Console.Error.WriteLine("Supported: .sln, .slnx, .csproj");

return null;

}

}

if (Directory.Exists(inputPath))

{

return null;

}

else

{

Console.Error.WriteLine($"Input path not found: {inputPath}");

return null;

}

}

@HorvathDaniel15 Is this really dead code, or Copilot just did not find its usage?

Copilot · 2026-04-04T18:06:56Z

+
+            foreach (var group in documentGroups)
+            {
+                tasks.Add(Task.Run(async () =>
+                {
+                    var options = new DbContextOptionsBuilder<CsharpDbContext>()
+                        .UseNpgsql(csharpConnectionString)
+                        .Options;
+                    var localDbContext = new CsharpDbContext(options);


localDbContext is created inside each worker task but never disposed. Since DbContext holds pooled connections and unmanaged resources, this can leak connections under load. Use (await) using for the context (and consider creating options once outside the loop).

Suggested change

foreach (var group in documentGroups)

{

tasks.Add(Task.Run(async () =>

{

var options = new DbContextOptionsBuilder<CsharpDbContext>()

.UseNpgsql(csharpConnectionString)

.Options;

var localDbContext = new CsharpDbContext(options);

var options = new DbContextOptionsBuilder<CsharpDbContext>()

.UseNpgsql(csharpConnectionString)

.Options;

foreach (var group in documentGroups)

{

tasks.Add(Task.Run(async () =>

{

await using var localDbContext = new CsharpDbContext(options);

This thread was resolved, but no fix is present in the codebase. Please provide a counter-argument if no code change is required.

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-21T09:09:34Z

+            Console.WriteLine($"Loading solution: {solutionPath}");
+            var workspace = CreateMsBuildWorkspace();
+
+            var solution = await workspace.OpenSolutionAsync(solutionPath);


The MSBuildWorkspace created here is not disposed. Since loading a solution can allocate significant resources, this can cause avoidable memory/file-handle usage. Wrap the workspace in a using/await using (or otherwise ensure Dispose() is called) once loading is complete.

Valid memory optimization concern.

Copilot · 2026-04-21T09:09:35Z

+            if (projectPaths.Count == 0)
+            {
+                Console.Error.WriteLine($"No C# projects found in solution: {solutionPath}");
+                return;


When no C# projects are found in the solution, this method logs an error and returns, but Main will still exit with code 0. That makes the wrapper/parser treat the run as successful even though nothing was parsed. Consider propagating failure (e.g., return a bool/int result or throw) so Main can exit non-zero in this case.

Suggested change

return;

throw new InvalidOperationException(

$"No C# projects found in solution: {solutionPath}");

Valid concern, since in case of other input errors, the program return with a non-zero exit code.

Implement support multi projet for the csharp parser

a462838

Copilot AI review requested due to automatic review settings April 4, 2026 18:02

Copilot started reviewing on behalf of HorvathDaniel15 April 4, 2026 18:03 View session

HorvathDaniel15 closed this Apr 4, 2026

Copilot AI reviewed Apr 4, 2026

View reviewed changes

HorvathDaniel15 reopened this Apr 4, 2026

mcserep added Kind: Enhancement 🌟 Plugin: C# Issues related to the parsing and presentation of C# projects. labels Apr 14, 2026

mcserep added this to Lab and Roadmap Apr 14, 2026

mcserep changed the title ~~Implement support multi projet for the csharp parser~~ Multi project support for the C# parser Apr 14, 2026

github-project-automation Bot moved this to In progress in Lab Apr 14, 2026

github-project-automation Bot moved this to In progress in Roadmap Apr 14, 2026

mcserep assigned HorvathDaniel15 Apr 14, 2026

mcserep self-requested a review April 14, 2026 09:08

mcserep linked an issue Apr 14, 2026 that may be closed by this pull request

Support multi-project parsing for the C# plugin #823

Open

mcserep added this to the Upcoming Release milestone Apr 14, 2026

mcserep mentioned this pull request Apr 21, 2026

Remove -b flag for C# parser #846

Open

mcserep requested a review from Copilot April 21, 2026 09:05

Copilot started reviewing on behalf of mcserep April 21, 2026 09:06 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

Fix issues

1bf2bd8

mcserep mentioned this pull request Apr 28, 2026

Use Roslyn to load project dependencies and create a semantic model #855

Open

		Console.Error.WriteLine($"Unsupported file type: {primaryInput}");
		Console.Error.WriteLine("Supported: .sln, .slnx, .csproj");

	return;
	throw new InvalidOperationException(
	$"No C# projects found in solution: {solutionPath}");

Conversation

HorvathDaniel15 commented Apr 4, 2026 • edited by mcserep Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

mcserep May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

mcserep May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

mcserep May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

mcserep May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

mcserep May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

mcserep Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

mcserep Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HorvathDaniel15 commented Apr 4, 2026 •

edited by mcserep

Loading